Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove Oj #933

Merged
merged 1 commit into from
Dec 19, 2024
Merged

Remove Oj #933

merged 1 commit into from
Dec 19, 2024

Conversation

santib
Copy link
Member

@santib santib commented Dec 19, 2024

Once we upgrade to Ruby 3.4 Ruby native JSON implementation will receive many performance improvements. That said, I don't think oj should be here by default, so I'd remove it right now and not wait until christmas.

https://github.com/ruby/json/blob/master/CHANGES.md

https://byroot.github.io/ruby/json/2024/12/15/optimizing-ruby-json-part-1.html

@santib santib requested a review from a team December 19, 2024 15:37
Copy link
Contributor

@enzofab91 enzofab91 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🧹

@santib santib merged commit e1f08d4 into main Dec 19, 2024
7 checks passed
@santib santib deleted the remove-oj branch December 19, 2024 17:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants