rm warning as this is normal behavior, adjust test, fixes #128

ropensci · Apr 23, 2024 · 1741890 · 1741890
1 parent afdb1dc
commit 1741890
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 8 deletions.
diff --git a/R/digests.R b/R/digests.R
@@ -42,25 +42,24 @@
     changed <- names(new_digest)[ unlist(new_digest[existed]) != unlist(old_digest[existed]) ]
     if(length(changed) > 0){
       for(name in changed){
-        .multilog_warn(paste(name, "has changed."))
+        .multilog_info(paste(name, "has changed."))
       }
-      warning()
       return(FALSE)
     }
   }
 
   for(name in removed){
-    .multilog_debug(paste(name, "was removed."))
+    .multilog_info(paste(name, "was removed."))
     return(FALSE)
   }
 
   for(name in added){
-    .multilog_debug(paste(name, "was added."))
+    .multilog_info(paste(name, "was added."))
     return(FALSE)
   }
 
   return(TRUE)
-};
+}
 
 .combine_digests <- function(new, old) {
   intersection <- intersect(names(new), names(old))

diff --git a/tests/testthat/test-updating-datapackager-version.R b/tests/testthat/test-updating-datapackager-version.R
@@ -25,9 +25,8 @@ test_that("can update", {
   oldDigest$cars_over_20<-"123456789"
   DataPackageR:::.save_digest(oldDigest,file.path(tempdir(),"subsetCars"))
 
-  suppressWarnings({
-    expect_warning(build_res <- package_build(file.path(tempdir(), "subsetCars")))
-  })
+
+  expect_no_warning(build_res <- package_build(file.path(tempdir(), "subsetCars")))
   expect_identical(
     build_res,
     normalizePath(file.path(tempdir(),"subsetCars_1.0.tar.gz"),winslash = "/")