Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

More refactoring of internal DataPackageR() function, bug fixes #129

Merged
merged 13 commits into from
Apr 23, 2024

Conversation

slager
Copy link
Contributor

@slager slager commented Apr 23, 2024

Continue simplifying and factoring out smaller functions from the giant internal DataPackageR() function:

  • validate_package_skeleton()
  • validate_yml()
  • get_yml_objects()
  • get_yml_r_files()

Fix #128

Misc fixes

  • case-sensitive filename tweak in test should resolve warning thrown on Linux GitHub Actions runners
  • Remove a logging file artifact that was accidentally committed in 2019

GitHub doesn't render the larger diffs very well due to some re-indenting

All tests still pass locally, and the only user-facing change is fixing the 3x warnings in #128.

@slager
Copy link
Contributor Author

slager commented Apr 23, 2024

Looks like f0f6e93 did indeed solve the testthat warning on the Linux CI runners. The codecov runner also successfully uploaded results to their server, so either this fixed #122 also or the upload problem is intermittent.

@slager slager merged commit b06f8c6 into develop Apr 23, 2024
9 checks passed
@slager slager deleted the refactor branch April 23, 2024 05:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant