Code

updates from review 1 by rOpenSci#71

Code

Merged

datapumpernickel merged 15 commits intomainropensci/comtradr:mainfrom devropensci/comtradr:devCopy head branch name to clipboardNov 17, 2023

+616-181

Commits

Commits on Nov 10, 2023

• allow user to control throttling manually

  datapumpernickel

  committed
  03141fd

  Copy full SHA for 03141fd

• add dev branch to tests and actions

  datapumpernickel

  committed
  7d60b6f

  Copy full SHA for 7d60b6f

Commits on Nov 11, 2023

• add grouping of functions for pkgdown

  datapumpernickel

  committed
  a22f365

  Copy full SHA for a22f365

• add pkgdown to buildignore

  datapumpernickel

  committed
  6423c5f

  Copy full SHA for 6423c5f

• sorted DESCRIPTION a bit

  datapumpernickel

  committed
  629cbfc

  Copy full SHA for 629cbfc

• made readme consistent with DESCRIPTION

  datapumpernickel

  committed
  5eb0418

  Copy full SHA for 5eb0418

• documented internal functions a bit more clearly, notably adding which functions call them

  datapumpernickel

  committed
  47da2c0

  Copy full SHA for 47da2c0

Commits on Nov 12, 2023

• added examples to internal functions and added comtradr::: so the examples woudl work

  datapumpernickel

  committed
  bf01c46

  Copy full SHA for bf01c46

Commits on Nov 13, 2023

• good practice, make lines shorter

  datapumpernickel

  committed
  4b6946f

  Copy full SHA for 4b6946f

• corrected spell checking, added to no spell check non-positive finds

  datapumpernickel

  committed
  6eb6616

  Copy full SHA for 6eb6616

• long line in lint

  datapumpernickel

  committed
  e281508

  Copy full SHA for e281508

Commits on Nov 17, 2023

• adjust max response limit to 100k, was erroneously 250k

  datapumpernickel

  committed
  039ab08

  Copy full SHA for 039ab08

• new test with response object

  datapumpernickel

  committed
  2929e95

  Copy full SHA for 2929e95

• include headers in mock dir for goods

  datapumpernickel

  committed
  ed69e72

  Copy full SHA for ed69e72

• updated service endpoint mock_dir with valid data

  datapumpernickel

  committed
  0a9c660

  Copy full SHA for 0a9c660