Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MAINT: Possibly hide functions which shouldn't be called by users #64

Closed
HaoZeke opened this issue Oct 25, 2023 · 1 comment
Closed
Labels
ropensci-review Issues related to the ROpenSci review

Comments

@HaoZeke
Copy link
Member

HaoZeke commented Oct 25, 2023

If the users are not supposed to be calling the lower level functions, do they need to be exported, and thus being part of the public user interface of the package? It could be less confusing possibly if only those functions are exported which are meant to be called directly by users.

First noted here: ropensci/software-review#606 (comment)

@HaoZeke HaoZeke added the ropensci-review Issues related to the ROpenSci review label Oct 25, 2023
@HaoZeke
Copy link
Member Author

HaoZeke commented Oct 25, 2023

Response from here: ropensci/software-review#606 (comment)

I thought about this, but decided not to mainly because downstream package users (including me for other dependent packages) would want to call these functions where it makes sense (e.g. if my downstream package will only write matrix data or sparse matrix data) and CRAN disallows / warns calling unexported functions via :::

@HaoZeke HaoZeke closed this as completed Oct 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ropensci-review Issues related to the ROpenSci review
Projects
None yet
Development

No branches or pull requests

1 participant