Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Demote sp and raster to suggests #332

Closed
Robinlovelace opened this issue Sep 2, 2019 · 7 comments
Closed

Demote sp and raster to suggests #332

Robinlovelace opened this issue Sep 2, 2019 · 7 comments

Comments

@Robinlovelace
Copy link
Member

Will speed up install times, could lead to future depreciation.

@Robinlovelace
Copy link
Member Author

Bumped up priority list.

@Robinlovelace
Copy link
Member Author

OK going to work on this after mentioning as a priority in #362

@Robinlovelace
Copy link
Member Author

Work on this: #481

@Robinlovelace
Copy link
Member Author

Some insight into dependencies in v1.8.7, x marks ones targetted for removal:

Imports:
    sp (>= 1.3.1), x
    curl (>= 3.2), x
    dplyr (>= 0.7.6),
    httr (>= 1.3.1),
    jsonlite (>= 1.5),
    stringr (>= 1.3.1),
    maptools (>= 0.9.3), x
    raster (>= 2.6.7), x
    rgeos (>= 0.3.28), x
    methods,
    geosphere (>= 1.5.7),
    Rcpp (>= 0.12.1),
    nabor (>= 0.5.0),
    rlang (>= 0.2.2),
    lwgeom (>= 0.1.4),
    sf (>= 0.6.3),
    magrittr,
    sfheaders,
    data.table,
    pbapply
dg = miniCRAN::makeDepGraph(pkg = "stplanr", includeBasePkgs = FALSE, suggests = FALSE)
plot(dg) # mass of pkgs

dg_betweenness = igraph::betweenness(dg)
summary(dg_betweenness)
#>    Min. 1st Qu.  Median    Mean 3rd Qu.    Max. 
#>   0.000   0.000   0.000   1.879   2.792  19.500
class(dg_betweenness)
#> [1] "numeric"
dg_many = dg_betweenness > 1
# dg_small = igraph::delete_vertices(graph = dg, v = dg_many)
dg_small = igraph::induced_subgraph(graph = dg, which(dg_many))
plot(dg_small)

Created on 2022-04-03 by the reprex package (v2.0.1)

Robinlovelace added a commit that referenced this issue Apr 3, 2022
Robinlovelace added a commit that referenced this issue Apr 3, 2022
Robinlovelace added a commit that referenced this issue Apr 4, 2022
@Robinlovelace
Copy link
Member Author

geosphere and raster also import sp so must be made Suggests or removed.

@Robinlovelace
Copy link
Member Author

A benefit of this refactoring work is that the package will be lighter. Latest version of the zips: https://github.com/ropensci/stplanr/archive/refs/heads/master.zip the package is 7.1 MB, a bit on the big side...

@Robinlovelace
Copy link
Member Author

Promising result, only 2 NOTEs to fix on win devel test: https://win-builder.r-project.org/KN7sTaJ8LeFF/00check.log

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant