Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Set transient local to audio info publisher #257

Open
wants to merge 2 commits into
base: ros2
Choose a base branch
from
Open

Set transient local to audio info publisher #257

wants to merge 2 commits into from

Conversation

Tacha-S
Copy link

@Tacha-S Tacha-S commented Jan 8, 2025 •
edited
Loading

I set the QoS durability of audio_info to Transient Local.

As it was in ROS noetic.

audio_common/audio_capture/src/audio_capture.cpp

Line 45 in 6a84996

_pub_info = _nh.advertise<audio_common_msgs::AudioInfo>("audio_info", 1, true);

@knorth55
Copy link
Member

@Tacha-S

JFYI:
As you know, CI is failing because of the disappointing situation of ROS2 upstream (cmake related issue).
So, now I will change my mind and change the package name to solve the issue. 😢
I will make package name difference between ROS1 and ROS2.

@knorth55
Copy link
Member

@Tacha-S could you resolve the conflict?

@Tacha-S
Copy link
Author

Tacha-S commented Jan 22, 2025

@knorth55 Sorry for not noticing the conflict.
I resolved the conflicts while merging the latest ROS2 branch.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@knorth55 knorth55 knorth55 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Tacha-S @knorth55