Add standard tests for rqt_bag and rqt_bag_plugins #171
Conversation
This ensures the package is up to our standards. Signed-off-by: Chris Lalancette <clalancette@gmail.com>
This just makes sure it is up to our standards. Signed-off-by: Chris Lalancette <clalancette@gmail.com>
|
Pulls: #171
|
Signed-off-by: Chris Lalancette <clalancette@gmail.com>
|
This pull request has been mentioned on ROS Discourse. There might be relevant details there: https://discourse.ros.org/t/ros-news-for-the-week-of-december-30th-2024-2025/41389/1 |
rqt_bag/src/rqt_bag/bag_timeline.py
Outdated
| listen_type = type(listener) | ||
| qWarning('Error calling timeline_changed on %s: %s' % (listen_type, str(ex))) |
There was a problem hiding this comment.
You're saving a single character with the assignment. Might as well use an f-string and keep it on one line.
| listen_type = type(listener) | |
| qWarning('Error calling timeline_changed on %s: %s' % (listen_type, str(ex))) | |
| qWarning(f'Error calling timeline_changed on {type(listener)}: {str(ex)}') |
| @@ -89,7 +84,7 @@ def start_clock_publishing(self): | |||
| def stop_clock_publishing(self): | |||
| self._publish_clock = False | |||
| if CLOCK_TOPIC in self._publishers: | |||
| self._node.destroy_publisher(self._publishers[topic]) | |||
| self._node.destroy_publisher(self._publishers[CLOCK_TOPIC]) | |||
There was a problem hiding this comment.
This looks like a bug fix. Might be better brought out on it's own PR.
rqt_bag/src/rqt_bag/recorder.py
Outdated
| from queue import Empty | ||
| from queue import Queue |
There was a problem hiding this comment.
| from queue import Empty | |
| from queue import Queue | |
| from queue import Empty, Queue |
Signed-off-by: Alejandro Hernández Cordero <ahcorde@gmail.com>
This ensures that these two packages are up to our standards.