wsm and ftm woo #120
Merged
wsm and ftm woo #120
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yabirgb
reviewed
Oct 12, 2023
There was a problem hiding this comment.
You should create release 21 since 20 has been already released, people won't get this assets if they already have v 20. As you can see is already in master https://github.com/rotki/assets/tree/master/updates/20
updates/20/updates.sql
Outdated
| * | ||
| INSERT INTO assets(identifier, name, type) VALUES("eip155:1/erc20:0xB62E45c3Df611dcE236A6Ddc7A493d79F9DFadEf", "Wall Street Memes", "C"); INSERT INTO evm_tokens(identifier, token_kind, chain, address, decimals, protocol) VALUES("eip155:1/erc20:0xB62E45c3Df611dcE236A6Ddc7A493d79F9DFadEf", "A", 1, "0xB62E45c3Df611dcE236A6Ddc7A493d79F9DFadEf", 18, NULL); INSERT INTO common_asset_details(identifier, symbol, coingecko, cryptocompare, forked, started, swapped_for) VALUES("eip155:1/erc20:0xB62E45c3Df611dcE236A6Ddc7A493d79F9DFadEf", "WSM", "wall-street-memes", "", NULL, 1697101248, NULL); | ||
| * | ||
| INSERT INTO assets(identifier, name, type) VALUES("eip155:250/erc20:0x6626c47c00F1D87902fc13EECfaC3ed06D5E8D8a", "WOO Network", "C"); INSERT INTO evm_tokens(identifier, token_kind, chain, address, decimals, protocol) VALUES("eip155:250/erc20:0x6626c47c00F1D87902fc13EECfaC3ed06D5E8D8a", "A", 250, "0x6626c47c00F1D87902fc13EECfaC3ed06D5E8D8a", 18, NULL); INSERT INTO common_asset_details(identifier, symbol, coingecko, cryptocompare, forked, started, swapped_for) VALUES("eip155:250/erc20:0x6626c47c00F1D87902fc13EECfaC3ed06D5E8D8a", "WOO", "woo-network", "", NULL, 1697101248, NULL); |
There was a problem hiding this comment.
woo network seems to be at cryptocompare
Suggested change
| INSERT INTO assets(identifier, name, type) VALUES("eip155:250/erc20:0x6626c47c00F1D87902fc13EECfaC3ed06D5E8D8a", "WOO Network", "C"); INSERT INTO evm_tokens(identifier, token_kind, chain, address, decimals, protocol) VALUES("eip155:250/erc20:0x6626c47c00F1D87902fc13EECfaC3ed06D5E8D8a", "A", 250, "0x6626c47c00F1D87902fc13EECfaC3ed06D5E8D8a", 18, NULL); INSERT INTO common_asset_details(identifier, symbol, coingecko, cryptocompare, forked, started, swapped_for) VALUES("eip155:250/erc20:0x6626c47c00F1D87902fc13EECfaC3ed06D5E8D8a", "WOO", "woo-network", "", NULL, 1697101248, NULL); | |
| INSERT INTO assets(identifier, name, type) VALUES("eip155:250/erc20:0x6626c47c00F1D87902fc13EECfaC3ed06D5E8D8a", "WOO Network", "C"); INSERT INTO evm_tokens(identifier, token_kind, chain, address, decimals, protocol) VALUES("eip155:250/erc20:0x6626c47c00F1D87902fc13EECfaC3ed06D5E8D8a", "A", 250, "0x6626c47c00F1D87902fc13EECfaC3ed06D5E8D8a", 18, NULL); INSERT INTO common_asset_details(identifier, symbol, coingecko, cryptocompare, forked, started, swapped_for) VALUES("eip155:250/erc20:0x6626c47c00F1D87902fc13EECfaC3ed06D5E8D8a", "WOO", "woo-network", "WOO", NULL, 1697101248, NULL); |
updates/20/updates.sql
Outdated
| * | ||
| INSERT INTO assets(identifier, name, type) VALUES("eip155:1/erc20:0xB62E45c3Df611dcE236A6Ddc7A493d79F9DFadEf", "Wall Street Memes", "C"); INSERT INTO evm_tokens(identifier, token_kind, chain, address, decimals, protocol) VALUES("eip155:1/erc20:0xB62E45c3Df611dcE236A6Ddc7A493d79F9DFadEf", "A", 1, "0xB62E45c3Df611dcE236A6Ddc7A493d79F9DFadEf", 18, NULL); INSERT INTO common_asset_details(identifier, symbol, coingecko, cryptocompare, forked, started, swapped_for) VALUES("eip155:1/erc20:0xB62E45c3Df611dcE236A6Ddc7A493d79F9DFadEf", "WSM", "wall-street-memes", "", NULL, 1697101248, NULL); | ||
| * | ||
| INSERT INTO assets(identifier, name, type) VALUES("eip155:250/erc20:0x6626c47c00F1D87902fc13EECfaC3ed06D5E8D8a", "WOO Network", "C"); INSERT INTO evm_tokens(identifier, token_kind, chain, address, decimals, protocol) VALUES("eip155:250/erc20:0x6626c47c00F1D87902fc13EECfaC3ed06D5E8D8a", "A", 250, "0x6626c47c00F1D87902fc13EECfaC3ed06D5E8D8a", 18, NULL); INSERT INTO common_asset_details(identifier, symbol, coingecko, cryptocompare, forked, started, swapped_for) VALUES("eip155:250/erc20:0x6626c47c00F1D87902fc13EECfaC3ed06D5E8D8a", "WOO", "woo-network", "", NULL, 1697101248, NULL); |
There was a problem hiding this comment.
You have the same timestamp in both, that seems wrong. You can go to the tx deploying them, get the timestamp and use it here
jbrit
force-pushed
the
feat/woo-exchange
branch
from
8bc9b15
to
7485509
Compare
jbrit
force-pushed
the
feat/woo-exchange
branch
from
7485509
to
5ba08af
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.