Fix (Assets): Group natives with wraps #180
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
OjusWiZard
force-pushed
the
fix/assets
branch
2 times, most recently
from
3244425
to
3ce58cf
Compare
yabirgb
reviewed
Aug 23, 2024
updates/28/updates.sql
Outdated
Comment on lines
3
to
4
| UPDATE common_asset_details SET swapped_for="eip155:1/erc20:0x455e53CBB86018Ac2B8092FdCd39d8444aFFC3F6" WHERE identifier="eip155:1/erc20:0x7D1AfA7B718fb893dB30A3aBc0Cfc608AaCfeBB0"; | ||
| INSERT INTO assets(identifier, name, type) VALUES("eip155:1/erc20:0x7D1AfA7B718fb893dB30A3aBc0Cfc608AaCfeBB0", "Matic Network", "C"); INSERT INTO evm_tokens(identifier, token_kind, chain, address, decimals, protocol) VALUES("eip155:1/erc20:0x7D1AfA7B718fb893dB30A3aBc0Cfc608AaCfeBB0", "A", 1, "0x7D1AfA7B718fb893dB30A3aBc0Cfc608AaCfeBB0", 18, ""); INSERT INTO common_asset_details(identifier, symbol, coingecko, cryptocompare, forked, started, swapped_for) VALUES("eip155:1/erc20:0x7D1AfA7B718fb893dB30A3aBc0Cfc608AaCfeBB0", "MATIC", "matic-network", "matic", NULL, 1503906828, "eip155:1/erc20:0x455e53CBB86018Ac2B8092FdCd39d8444aFFC3F6"); |
There was a problem hiding this comment.
SEems that this is doing something weird
There was a problem hiding this comment.
okay so I thought they are the same and it's a simple "swapped for". But, actually they should be treated differently, so I'm removing this change. It's fine as it is right now.
OjusWiZard
force-pushed
the
fix/assets
branch
2 times, most recently
from
1f77b93
to
9e17a44
Compare
Signed-off-by: OjusWiZard <ojuswimail@gmail.com>
OjusWiZard
force-pushed
the
fix/assets
branch
from
9e17a44
to
f8e76ea
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes https://github.com/orgs/rotki/projects/11/views/2?pane=issue&itemId=73676916