fix(Button): propagate listeners to button

rotki · Oct 19, 2023 · 186d7c7 · 186d7c7
1 parent bffad08
commit 186d7c7
Show file tree

Hide file tree

Showing 2 changed files with 9 additions and 5 deletions.
diff --git a/example/src/components/AppNav.vue b/example/src/components/AppNav.vue
@@ -9,7 +9,7 @@ import {
 } from '@rotki/ui-library-compat';
 
 const css = useCssModule();
-const { switchThemeScheme } = useRotkiTheme();
+const { switchThemeScheme, store } = useRotkiTheme();
 
 interface Theme {
   name: string;
@@ -40,10 +40,11 @@ const onSwitchTheme = ({ value }: Theme) => switchThemeScheme(value);
         class="relative flex basis-0 justify-end gap-6 sm:gap-8 md:flex-grow"
       >
         <span class="sr-only">Theme</span>
-        <RuiButtonGroup variant="outlined">
+        <RuiButtonGroup :value="store" variant="outlined">
           <RuiButton
             v-for="theme in themes"
             :key="theme.value"
+            :value="theme.value"
             @click="onSwitchTheme(theme)"
           >
             <RuiIcon :name="theme.icon" :size="16" />

diff --git a/src/components/buttons/button/Button.vue b/src/components/buttons/button/Button.vue
@@ -73,8 +73,7 @@ const spinnerSize: ComputedRef<number> = computed(() => {
   return 22;
 });
 
-const onClick = (event: PointerEvent) => {
-  emit('click', event);
+const onClick = () => {
   emit('input', get(value));
 };
 
@@ -99,7 +98,11 @@ const slots = useSlots();
     ]"
     :disabled="disabled || loading"
     v-bind="attrs"
-    @click="onClick($event)"
+    v-on="
+      // eslint-disable-next-line vue/no-deprecated-dollar-listeners-api
+      $listeners
+    "
+    @click="onClick()"
   >
     <slot v-if="slots.prepend" name="prepend" />
     <span v-if="slots.default" :class="css.label"> <slot /> </span>