Skip to content
This repository has been archived by the owner on Sep 30, 2024. It is now read-only.

feat(AutoComplete): add some missing props #200

Merged
merged 2 commits into from
May 24, 2024

Conversation

lukicenturi
Copy link
Contributor

Closes #(issue_number)

@lukicenturi lukicenturi requested a review from a team as a code owner May 23, 2024 14:16
@lukicenturi lukicenturi force-pushed the add-some-missing-prop-for-autocomplete branch 2 times, most recently from 5abcda2 to 4900949 Compare May 24, 2024 08:25
@lukicenturi lukicenturi force-pushed the add-some-missing-prop-for-autocomplete branch from 4900949 to dbdc232 Compare May 24, 2024 08:27
@lukicenturi lukicenturi force-pushed the add-some-missing-prop-for-autocomplete branch from 43bcb00 to 842b7a7 Compare May 24, 2024 11:09
@codecov-commenter
Copy link

Codecov Report

Attention: Patch coverage is 95.27027% with 7 lines in your changes are missing coverage. Please review.

Project coverage is 67.52%. Comparing base (1aa5495) to head (842b7a7).

Files Patch % Lines
...components/forms/auto-complete/RuiAutoComplete.vue 94.59% 4 Missing ⚠️
src/composables/dropdown-menu.ts 88.00% 3 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #200      +/-   ##
==========================================
+ Coverage   67.33%   67.52%   +0.18%     
==========================================
  Files         103      103              
  Lines       18237    18332      +95     
  Branches      639      649      +10     
==========================================
+ Hits        12280    12378      +98     
+ Misses       5957     5954       -3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@kelsos kelsos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am gonna merge and think a bit more about how to properly type for vue3

@kelsos kelsos merged commit c962a4b into rotki:main May 24, 2024
5 checks passed
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants