Skip to content
This repository has been archived by the owner on Sep 30, 2024. It is now read-only.

feat(AutoComplete): allow AutoComplete to accept custom value #201

Merged
merged 1 commit into from
Jun 4, 2024

Conversation

lukicenturi
Copy link
Contributor

Closes #(issue_number)

@lukicenturi lukicenturi requested a review from a team as a code owner June 3, 2024 11:53
@lukicenturi lukicenturi force-pushed the autocomplete-support-custom-value branch from 88d0a0a to f4fdd00 Compare June 3, 2024 12:07
@codecov-commenter
Copy link

Codecov Report

Attention: Patch coverage is 88.97059% with 15 lines in your changes are missing coverage. Please review.

Project coverage is 67.67%. Comparing base (b4ae569) to head (f4fdd00).

Files Patch % Lines
...components/forms/auto-complete/RuiAutoComplete.vue 91.86% 10 Missing ⚠️
src/composables/dropdown-menu.ts 58.33% 5 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #201      +/-   ##
==========================================
+ Coverage   67.52%   67.67%   +0.15%     
==========================================
  Files         103      103              
  Lines       18332    18443     +111     
  Branches      649      677      +28     
==========================================
+ Hits        12378    12481     +103     
- Misses       5954     5962       +8     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@kelsos kelsos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@kelsos kelsos merged commit f4fdd00 into rotki:main Jun 4, 2024
5 checks passed
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants