Skip to content
This repository has been archived by the owner on Sep 30, 2024. It is now read-only.

feat(AutoComplete): allow AutoComplete to accept custom value #201

Merged
merged 1 commit into from
Jun 4, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion example/cypress/e2e/forms/autocomplete.cy.ts
Original file line number Diff line number Diff line change
Expand Up @@ -17,6 +17,6 @@ describe('forms/Auto Completes', () => {
cy.get('div[role=menu]').should('be.visible');
cy.get('div[role=menu] button:first-child').click();

cy.get('@firstAutoComplete').find('div[class*=_value_]').should('contain.text', 'Germany');
cy.get('@firstAutoComplete').find('input').should('have.value', 'Germany');
});
});
32 changes: 32 additions & 0 deletions example/src/views/AutoCompleteView.vue
Original file line number Diff line number Diff line change
Expand Up @@ -211,6 +211,38 @@ const autoCompletePrimitive = ref<AutoCompleteProps<string>[]>([
label: 'Multiple',
options: primitiveOptions,
},
{
value: undefined,
variant: 'outlined',
label: 'Custom Value',
customValue: true,
options: primitiveOptions,
},
{
value: undefined,
dense: true,
variant: 'outlined',
label: 'Custom Value',
customValue: true,
options: primitiveOptions,
},
{
value: [],
chips: true,
dense: true,
variant: 'outlined',
label: 'Multiple With Custom Value',
customValue: true,
options: primitiveOptions,
},
{
value: ['Lorem'],
dense: true,
variant: 'outlined',
label: 'Multiple With Custom Value',
customValue: true,
options: primitiveOptions,
},
]);

function getDisplayText(options?: Options | Options[]): string {
Expand Down
45 changes: 36 additions & 9 deletions src/components/forms/auto-complete/RuiAutoComplete.spec.ts
Original file line number Diff line number Diff line change
Expand Up @@ -56,7 +56,7 @@ describe('autocomplete', () => {
},
});
expect(wrapper.find('div[data-id=activator][tabindex=-1]').exists()).toBeTruthy();
expect(wrapper.find('div[data-id=activator][tabindex=-1]').text()).toMatch('Spain');
expect((wrapper.find('div[data-id=activator][tabindex=-1] input').element as HTMLInputElement).value).toMatch('Spain');
});

it('works with primitive options', () => {
Expand All @@ -66,11 +66,12 @@ describe('autocomplete', () => {
value: options[4].label,
},
});
expect(wrapper.find('div[data-id=activator]').text()).toMatch('Spain');
expect((wrapper.find('div[data-id=activator] input').element as HTMLInputElement).value).toMatch('Spain');
});

it('value passed and emitted properly', async () => {
const wrapper = createWrapper({
attachTo: document.body,
propsData: {
autoSelectFirst: true,
keyAttr: 'id',
Expand Down Expand Up @@ -104,8 +105,6 @@ describe('autocomplete', () => {

expect(document.body.querySelector('div[role=menu]')).toBeTruthy();

await nextTick();

highlightedItemButton = document.body.querySelector(`button:nth-child(${selectedIndex})`) as HTMLButtonElement;
expect(highlightedItemButton.classList).toContain('highlighted');

Expand Down Expand Up @@ -162,15 +161,43 @@ describe('autocomplete', () => {

chips = wrapper.find('div[data-id=activator]').findAll('.rui-chip');
expect(chips).toHaveLength(3);
expect(chips.at(0).text()).toBe('India');
expect(chips.at(1).text()).toBe('France');
expect(chips.at(2).text()).toBe('England');

expect(chips.at(0).text()).toBe('France');
expect(chips.at(1).text()).toBe('England');
expect(chips.at(2).text()).toBe('India');

// Delete England
await chips.at(2).find('button[type="button"]').trigger('click');
await chips.at(0).find('button[type="button"]').trigger('click');
await nextTick();

newValue = ['6', '7'];
newValue = ['8', '6'];
expect(wrapper.emitted().input!.at(-1)![0]).toEqual(newValue);
});

it('custom value', async () => {
const wrapper = createWrapper({
propsData: {
autoSelectFirst: true,
chips: true,
customValue: true,
keyAttr: 'id',
options,
textAttr: 'label',
value: ['custom value'],
},
});

expect(wrapper.find('div[data-id=activator]').exists()).toBeTruthy();
const chips = wrapper.find('div[data-id=activator]').findAll('.rui-chip');
expect(chips).toHaveLength(1);
expect(chips.at(0).text()).toBe('custom value');

await wrapper.find('input').setValue('custom value 2');
await wrapper.find('[data-id=activator]').trigger('keydown.enter');

expect(wrapper.emitted().input!.at(-1)![0]).toEqual([
'custom value',
'custom value 2',
]);
});
});
Loading
Loading