Skip to content
This repository has been archived by the owner on Sep 30, 2024. It is now read-only.

fix(AutoComplete): some issues #202

Merged
merged 2 commits into from
Jun 5, 2024
Merged

Conversation

lukicenturi
Copy link
Contributor

@lukicenturi lukicenturi commented Jun 5, 2024

  • expose focus and selection range
  • fix scrolling issue (reproduce: scroll to bottom, and then filter, then the scroll is not going up, it stucks)
  • hide menu when there's no options (and nothing in the menu)

@lukicenturi lukicenturi requested a review from a team as a code owner June 5, 2024 10:50
@codecov-commenter
Copy link

codecov-commenter commented Jun 5, 2024

Codecov Report

Attention: Patch coverage is 72.50000% with 11 lines in your changes missing coverage. Please review.

Project coverage is 67.68%. Comparing base (76241a5) to head (0554f9e).

Files Patch % Lines
src/composables/dropdown-menu.ts 70.83% 7 Missing ⚠️
...components/forms/auto-complete/RuiAutoComplete.vue 71.42% 4 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #202      +/-   ##
==========================================
+ Coverage   67.67%   67.68%   +0.01%     
==========================================
  Files         103      103              
  Lines       18443    18463      +20     
  Branches      677      678       +1     
==========================================
+ Hits        12481    12497      +16     
- Misses       5962     5966       +4     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@kelsos kelsos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@kelsos kelsos merged commit 641a182 into rotki:main Jun 5, 2024
5 checks passed
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants