Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update how icon registration works for library #288

Merged
merged 3 commits into from
Oct 9, 2024

Conversation

kelsos
Copy link
Member

@kelsos kelsos commented Oct 9, 2024

Closes #(issue_number)

@kelsos kelsos requested a review from a team as a code owner October 9, 2024 11:58
@codecov-commenter
Copy link

Codecov Report

Attention: Patch coverage is 90.90909% with 5 lines in your changes missing coverage. Please review.

Project coverage is 84.97%. Comparing base (5f8a280) to head (314d746).

Files with missing lines Patch % Lines
src/index.ts 0.00% 5 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #288      +/-   ##
==========================================
- Coverage   84.98%   84.97%   -0.02%     
==========================================
  Files         115      115              
  Lines       10378    10388      +10     
  Branches     1271     1271              
==========================================
+ Hits         8820     8827       +7     
- Misses       1558     1561       +3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@lukicenturi lukicenturi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@lukicenturi lukicenturi merged commit 7e34d84 into rotki:main Oct 9, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants