Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Steppers component #37

Merged
merged 11 commits into from
Jul 10, 2023
Merged

Add Steppers component #37

merged 11 commits into from
Jul 10, 2023

Conversation

tewshi
Copy link
Contributor

@tewshi tewshi commented Jul 6, 2023

Closes #19

@tewshi tewshi requested a review from a team as a code owner July 6, 2023 00:14
@lukicenturi
Copy link
Contributor

Is there anyway to show the current step like this?
image

I can't find it in the example

@tewshi
Copy link
Contributor Author

tewshi commented Jul 6, 2023

Is there anyway to show the current step like this? image

I can't find it in the example

yeah, you're right.

it was labelled as custom, so I made a slot for custom icon, but I'll add a wrapper and use the custom icons as we have here.

@lukicenturi
Copy link
Contributor

lukicenturi commented Jul 7, 2023

@tewshi I think for the custom one, you need to force the color to use rui-light-primary (force to use light mode primary color, in both light and dark mode) referring to the Figma.

Figma:
image

Yours:
image

So we can achieve this
image

Also is it possible to change the size of the icon for custom one, to match with the figma.
The icon on the figma is smaller. (I think this one is easy, just change the size from 26 to 20)

@lukicenturi
Copy link
Contributor

for the stepper with primary color, I think you need to set the color to black (white in dark mode), instead of primary (?), so then we can remove the customTitleColor.

Yours:
image

Figma:
image

@codecov-commenter
Copy link

Codecov Report

Merging #37 (388e726) into main (3e56988) will decrease coverage by 0.90%.
The diff coverage is 96.24%.

@@            Coverage Diff             @@
##             main      #37      +/-   ##
==========================================
- Coverage   98.76%   97.86%   -0.90%     
==========================================
  Files           7       12       +5     
  Lines         727     1125     +398     
  Branches       36       48      +12     
==========================================
+ Hits          718     1101     +383     
- Misses          9       24      +15     
Impacted Files Coverage Δ
src/components/steppers/StepperIcon.vue 88.73% <88.73%> (ø)
src/components/steppers/Stepper.vue 96.41% <96.41%> (ø)
src/components/steppers/Stepper.spec.ts 100.00% <100.00%> (ø)
src/components/steppers/StepperCustomIcon.vue 100.00% <100.00%> (ø)
src/composables/icons.ts 100.00% <100.00%> (ø)
src/types/stepper.ts 100.00% <100.00%> (ø)

Copy link
Contributor

@lukicenturi lukicenturi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Copy link
Member

@kelsos kelsos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@kelsos kelsos merged commit 7af3e73 into rotki:main Jul 10, 2023
4 checks passed
@tewshi tewshi added this to the v0.1.0 milestone Jul 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Stepper: Create stepper component
4 participants