-
Notifications
You must be signed in to change notification settings - Fork 63
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[MAUI] [Android] Sharpnado tabs become unusable in combination with MAUI Shell Tabbar #120
Comments
I verified that the problem occurs also with the latest MAUI version 8.0.90 and down to 8.0.7. |
seems like a good first issue for the new contributor of the repo ;) |
I can confirm this issue repro in my scenario |
For completeness: It also happens with .NET 7 (and with 8.0.81, which was released in the meantime). By now I suspect that it's rather a bug in Sharpnado.Tabs (and not in the MAUI framework). |
* reproducer for roubachof#120
I now also set up a reproducer directly in my fork of the Sharpnado.Tabs repo, so that one can debug it directly (together with the lib, and not via the nupkg): https://github.com/janusw/Sharpnado.Tabs/commits/MauiShellSample/ From the log output and some debugging, I see that @roubachof Do you have any ideas how to debug this? Or some suggestions what to try? |
should be linked to this: #84 maybe? |
Quite probable that this is related. Thanks for the pointer! #84 (comment) mentions a solution concerning
|
yup, that's the same for all controls actually. |
I tried the following in the
However, this does not seem to fix the problem. Any comments? #84 (comment) says:
Am I doing the wrong thing here? Or maybe it is a different issue, after all ...?!? |
well it's not linked to #84 since I cannot reproduce the issue with .net8 |
should be fixed by v3.1.0, please re-open if it doesn't. |
Well, yes, I can confirm that v3.1.0 indeed fixes this problem on Android. Thanks! 👍 BUT: It looks like this release completely breaks iOS. The tabs do not react to tapping at all on iOS (observed with my own application, have not checked the sample yet). 😱 @roubachof Can you confirm this? Have you tested on iOS? |
CAn you set UseMauiTapGesture to true on the TabHostView ? |
Yes, indeed this makes the tab on iOS react again. Maybe it should be the default then (on iOS)? Or are there any downsides? |
I just tested on the sample and it's working fine : Simulator.Screen.Recording.-.iPhone.15.-.2024-10-21.at.11.08.15.mp4 |
Yes, it's working in principle (i.e. the tabs react to touching), but it's missing the touch effects on the main toolbar (where you set |
I don't understand... you said:
But it does react at tapping, you also have the color feedback. |
Ok, let's get this straight ....
This statement concerned my own app: The tabs on iOS did not react at all. This is fixed by using
Now you're talking about the However, the color effect when tapping seems to be removed by Btw, I also checked that the tabs are reacting in the MauiShellSample. I'm not sure why it did not work in my case.
Right, I did not mean to say that my PR is better than what you did. 😉 The other way around: Your implementation has the same problem as my naive PR. 😆 (but at least you added a property to switch it). Would be nice to have one solution that fully works everywhere instead of having workarounds for specific cases. IIUC, you may need to get rid of the old effects anyway for .NET 9 (in MAUI they we're only kept for compatibility with Xamarin, but it seems like .NET 9 finally removes this compatibility) ... |
I am so lost right now :) |
Alright 👍 (#130 seems related). But you can confirm that the touch effect on the sample's main tab bar is missing right now? That's a "regression" in the sample, in a way. |
When you are using UseMauiGesture, it uses maui vanilla gesturen which has no touch effect or tap sound |
Platform (please complete the following information):
Describe the bug
I see strange behavior of a Sharpnado tab bar inside a MAUI application with Shell Tabbar. In certain situations the Sharpnado tabs become unusable and don't react any more.
I'm not actually sure if this is a bug in the MAUI framework itself, or in Sharpnado.Tabs (could be both, I guess).
To Reproduce
Steps to reproduce the behavior:
ShellTabBarSample
in my fork of themaui-samples
).The text was updated successfully, but these errors were encountered: