Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Include testrunner image in this repo #257

Closed
pabzm opened this issue Jul 1, 2024 · 4 comments
Closed

Include testrunner image in this repo #257

pabzm opened this issue Jul 1, 2024 · 4 comments
Assignees

Comments

@pabzm
Copy link
Member

pabzm commented Jul 1, 2024

I built a docker-compose based setup to locally run the tests for roundcubemail using a custom docker image. To reduce execution times of the test runs I'd like to use service-containers in the CI workflows, too. For that we'd need downloadable images with several PHP versions.

@alecpl suggested to store the scripts and build the images in this repository.

Would you agree to set that up here if I post a PR?

@pabzm pabzm self-assigned this Jul 1, 2024
@alecpl
Copy link
Member

alecpl commented Jul 1, 2024

@alecpl suggested to store the scripts and build the images in this repository.

Actually, I just said I don't want any docker files in the roundcubemail repo root.

@pabzm
Copy link
Member Author

pabzm commented Jul 1, 2024

I didn't mean to misquote you, sorry for the misunderstanding.

Your position is not quite clear to me: do you prefer the Dockerfiles and related scripts (including the workflows to build the images) in the main repo or in this one? (For me both variants are fine.)

@alecpl
Copy link
Member

alecpl commented Jul 1, 2024

Your position is not quite clear to me: do you prefer the Dockerfiles and related scripts (including the workflows to build the images) in the main repo or in this one? (For me both variants are fine.)

Sorry if I wasn't clear. I don't really care about docker, but I know if we put Dockerfile in Roundcube root folder, it will be confusing considering that roundcubemail-docker exists. If you can make it working with .ci/Dockerfile I'm fine with that.

@pabzm
Copy link
Member Author

pabzm commented Jul 1, 2024

Thank you for the explanation, so I'll continue in the main repo! 👍

@pabzm pabzm closed this as completed Jul 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants