Fix "increment_style" CS (#9296)

* Fix "increment_style" CS * use "post" increment style
roundcube · Jan 1, 2024 · 86eda9f · 86eda9f
1 parent f509142
commit 86eda9f
Show file tree

Hide file tree

Showing 11 changed files with 16 additions and 14 deletions.
diff --git a/.php-cs-fixer.dist.php b/.php-cs-fixer.dist.php
@@ -77,6 +77,9 @@
 
         // disable too destructive formating for now
         'declare_strict_types' => false,
+        'increment_style' => [
+            'style' => 'post',
+        ],
         'no_useless_else' => false,
         'phpdoc_no_empty_return' => false,
         'psr_autoloading' => false,
@@ -94,7 +97,6 @@
             'import_symbols' => false,
         ],
         'general_phpdoc_annotation_remove' => false,
-        'increment_style' => false,
         'method_argument_space' => false,
         'modernize_types_casting' => false,
         'new_with_parentheses' => false,

diff --git a/plugins/archive/archive.php b/plugins/archive/archive.php
@@ -281,7 +281,7 @@ function move_messages()
 
         // jump back one page (user removed the whole last page)
         if ($page > 1 && $remaining == 0) {
-            --$page;
+            $page--;
             $storage->set_page($page);
             $_SESSION['page'] = $page;
             $jump_back = true;

diff --git a/plugins/managesieve/lib/Roundcube/rcube_sieve_script.php b/plugins/managesieve/lib/Roundcube/rcube_sieve_script.php
@@ -661,7 +661,7 @@ private function _parse_text($script)
                 if ($endl === false) {
                     $endl = $length;
                 } elseif ($script[$endl - 1] === "\r") {
-                    --$endl;
+                    $endl--;
                 }
                 $line = substr($script, $position, $endl - $position);
 

diff --git a/plugins/zipdownload/zipdownload.php b/plugins/zipdownload/zipdownload.php
@@ -401,7 +401,7 @@ public function filter($in, $out, &$consumed, $closing)
             // messages are read line by line
             if (preg_match('/^>*From /', $bucket->data)) {
                 $bucket->data     = '>' . $bucket->data;
-                ++$bucket->datalen;
+                $bucket->datalen++;
             }
 
             $consumed += $bucket->datalen;

diff --git a/program/actions/mail/check_recent.php b/program/actions/mail/check_recent.php
@@ -132,7 +132,7 @@ public function run($args = [])
                 if ($all_count && $page > 1) {
                     $remaining = $all_count - $page_size * ($page - 1);
                     if ($remaining <= 0) {
-                        --$page;
+                        $page--;
                         $rcmail->storage->set_page($page);
                         $_SESSION['page'] = $page;
                     }

diff --git a/program/actions/mail/delete.php b/program/actions/mail/delete.php
@@ -96,7 +96,7 @@ public function run($args = [])
 
         // jump back one page (user removed the whole last page)
         if ($page > 1 && $remaining == 0) {
-            --$page;
+            $page--;
             $rcmail->storage->set_page($page);
             $_SESSION['page'] = $page;
             $jump_back = true;

diff --git a/program/actions/mail/mark.php b/program/actions/mail/mark.php
@@ -137,7 +137,7 @@ public function run($args = [])
 
                 // jump back one page (user removed the whole last page)
                 if ($page > 1 && $remaining == 0) {
-                    --$page;
+                    $page--;
                     $rcmail->storage->set_page($page);
                     $_SESSION['page'] = $page;
                     $jump_back = true;

diff --git a/program/actions/mail/move.php b/program/actions/mail/move.php
@@ -114,7 +114,7 @@ public function run($args = [])
 
         // jump back one page (user removed the whole last page)
         if ($page > 1 && $remaining == 0) {
-            --$page;
+            $page--;
             $rcmail->storage->set_page($page);
             $_SESSION['page'] = $page;
             $jump_back = true;

diff --git a/program/lib/Roundcube/rcube_imap.php b/program/lib/Roundcube/rcube_imap.php
@@ -1361,7 +1361,7 @@ public function folder_status($folder = null, &$diff = [])
 
         // got new messages
         if ($new['maxuid'] > $old['maxuid']) {
-            ++$result;
+            $result++;
             // get new message UIDs range, that can be used for example
             // to get the data of these messages
             $diff['new'] = ($old['maxuid'] + 1 < $new['maxuid'] ? ($old['maxuid'] + 1) . ':' : '') . $new['maxuid'];
@@ -2189,7 +2189,7 @@ protected function structure_part($part, $count = 0, $parent = '', $mime_headers
         // read part disposition
         $di = 8;
         if ($struct->ctype_primary == 'text') {
-            ++$di;
+            $di++;
         }
         elseif ($struct->mimetype == 'message/rfc822') {
             $di += 3;

diff --git a/program/lib/Roundcube/rcube_tnef_decoder.php b/program/lib/Roundcube/rcube_tnef_decoder.php
@@ -533,7 +533,7 @@ protected function _decompressRTF($data, $size)
 
         for ($cnt = 0; $cnt < $length_preload; $cnt++) {
             $uncomp .= $preload[$cnt];
-            ++$out;
+            $out++;
         }
 
         while ($out < ($size + $length_preload)) {
@@ -559,12 +559,12 @@ protected function _decompressRTF($data, $size)
 
                 while ($offset < $end) {
                     $uncomp .= $uncomp[$offset++];
-                    ++$out;
+                    $out++;
                 }
             }
             else {
                 $uncomp .= $data[$in++];
-                ++$out;
+                $out++;
             }
         }
 

diff --git a/program/lib/Roundcube/rcube_vcard.php b/program/lib/Roundcube/rcube_vcard.php
@@ -972,7 +972,7 @@ private static function vcard_unquote($str, $sep = ';')
                 $str = substr_replace($str, '', $pos, 1);
             }
 
-            ++$pos;
+            $pos++;
         }
 
         return $str;