Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix CI tests on Windows #9602

Closed
pabzm opened this issue Aug 22, 2024 · 0 comments · Fixed by #9609
Closed

Fix CI tests on Windows #9602

pabzm opened this issue Aug 22, 2024 · 0 comments · Fixed by #9609
Assignees
Labels
github_actions Pull requests that update GitHub Actions code

Comments

@pabzm
Copy link
Member

pabzm commented Aug 22, 2024

Since #9525 the tests on windows apparently don't actually run but return after 1s without any message 🤔

Example action: https://github.com/roundcube/roundcubemail/actions/runs/10370034195/job/28707057004

@pabzm pabzm self-assigned this Aug 22, 2024
@pabzm pabzm added the github_actions Pull requests that update GitHub Actions code label Aug 22, 2024
pabzm referenced this issue Aug 22, 2024
* More ignore-patterns in eslint config

So we don't have to specify them on the command line when we check
codestyle locally.

* Test setup for local and CI using containers

It uses standalone containers for the greenmail IMAP server and the
standalone browser.
A testrunner image is built in the CI (for `linux/amd64` only, because
Github doesn't support multi-platform building on their default
runners and we don't have our own.)

This setup helps to run the tests (reproduceably) also locally.
Previously, on my machine, they produced varying results.
It also reduces the dependencies for running the browser test.
Local execution only depends on `docker compose`, no other tools
(previously it required `sudo`, `java`, and some more.)

The previous solution should still work, if you want it.

The scripts are stored in a directory called `.ci` to hide them a little
and avoid confusion with the container images from the
`roundcubemail-docker` repo.

* Fix UI tests by waiting for element before using it

This only was a flaky problem only occurring sometimes.

* Force a new IMAP connection in plugin tests, too

In other code the initial connection is forced. Doing this here, too,
fixes occasional problems with lost imap connections.

* Make waiting for zipfile's content more robust

* CI: Run tests from script on Windows, too

* CI: Do start local chrome if no connect URL is given

* Move compose.yml to tests/

This way it's less easy mistaken as usable for running Roundcubemail in
production.

* Move compose.yml to .ci/
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
github_actions Pull requests that update GitHub Actions code
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant