Assert expected data types in tests #9268
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mvorisek
changed the title
alecpl
requested changes
Dec 17, 2023
| @@ -56,7 +56,7 @@ function test_parse_bytes() | |||
|
|
|||
| foreach ($data as $value => $expected) { | |||
| $result = parse_bytes($value); | |||
| $this->assertEquals($expected, $result, "Invalid parse_bytes() result for $value"); | |||
| $this->{'assertEquals'}($expected, $result, "Invalid parse_bytes() result for $value"); | |||
There was a problem hiding this comment.
???? here and in some other places.
There was a problem hiding this comment.
{'assertEquals'} is a hack for PHP CS Fixer to still allow TestCase::assertEquals() to be used.
The (fixed) php_unit_strict rule is risky, so I reviewed them manually to prevent bad changed. Here, I would expect bytes to be parsed to integer, so I kept original assertEquals, so with a fix in future, the test will still pass. The fix/improvement is here: #9268. In that PR, the test is hardened to assertSame.
mvorisek
force-pushed
the
phpunit_strict_cmp
branch
from
886bf49
to
1486113
Compare
mvorisek
force-pushed
the
phpunit_strict_cmp
branch
from
1486113
to
588b11e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use
TestCase::assertSame()instead ofTestCase::assertEquals()which does not assert expected data type.Fix
php_unit_strictrule.