add invalid and error details to vcard import report #9605
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pabzm
requested changes
Sep 12, 2024
johndoh
force-pushed
the
vcard_import
branch
from
78e8d83
to
7eed125
Compare
alecpl
approved these changes
Sep 18, 2024
| @@ -162,6 +162,8 @@ $messages['importwait'] = 'Importing, please wait...'; | |||
| $messages['importformaterror'] = 'Import failed! The uploaded file is not a valid import data file.'; | |||
| $messages['importconfirm'] = '<b>Successfully imported $inserted contacts</b>'; | |||
| $messages['importconfirmskipped'] = '<b>Skipped $skipped existing entries</b>'; | |||
| $messages['importconfirminvalid'] = '<b>Skipped $invalid invalid entries</b>'; | |||
| $messages['importconfirmerrors'] = '<b>Failed to import $errors valid contacts</b>'; | |||
There was a problem hiding this comment.
We should probably get rid of HTML tags from all these three messages.
There was a problem hiding this comment.
I think removing the <b> tags would be a breaking change because the formatting should be moved to the skin to do this properly. I can work on this in a separate PR.
|
@alecpl I'll merge this in one week if nothing happens until then, since you left your approval already and the only open topic is very minor. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
for #9591
currently there are 2 silent error cases on vcard import, invalid (fails roundcube contact validation) and error (its valid but i didnt insert for some reason e.g. plugin prevented it) this adds messages about those to the screen.