Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add fully qualified backslash to all simple class usages #9680

Open
wants to merge 18 commits into
base: master
Choose a base branch
from

Conversation

mvorisek
Copy link
Contributor

extracted from #9481

let's land this in a separate PR and minimize future diffs/conflicts

@mvorisek mvorisek marked this pull request as ready for review October 26, 2024 09:31
@mvorisek mvorisek changed the title Make all class usages fully qualified Add fully qualified backslash to all simple class usages Oct 26, 2024
@mvorisek
Copy link
Contributor Author

mvorisek commented Nov 4, 2024

@alecpl I have rebased this PR, can it be merged to prevent further merge conflicts?

@mvorisek
Copy link
Contributor Author

@pabzm can you review/merge? I need this one for #9481.

@alecpl
Copy link
Member

alecpl commented Nov 17, 2024

I think I would prefer a use statements instead. Or we should do something with the release-1.6 code. Backporting anything has become hard.

@mvorisek
Copy link
Contributor Author

@alecpl thank you for the idea using import to minimize conflicts!

So I reworked this PR:
a) all non-intra project usages are newly with leading \ - this is how they should be imported once namespaced
b) all intra project usages in currently non-namespaced files are kept, but dummy use X as X; imports are added

After #9481 the dummy imports will be replaced with meaningful imports.

Code can stay as it is, so conflicts across release branches are minimal.

Leading \ for non-instra project usages is asserted by CI.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants