Debugger #46
Draft
Debugger #46
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rozukke
reviewed
Oct 5, 2024
Instead of `-d`/`--debugger-input`
This will get changed at some point, but I need it right now for development
dxrcy
commented
Jan 6, 2025
dxrcy
commented
Jan 7, 2025
There was a problem hiding this comment.
Keep in mind that a user will rarely have more than ~3 breakpoints, so performance isn't important.
dxrcy
commented
Jan 7, 2025
| /// Add the `orig` address to each [`Breakpoint`] item. | ||
| /// | ||
| /// Should only be called once per program run. | ||
| pub fn with_orig(mut self, orig: u16) -> Self { |
There was a problem hiding this comment.
More explicit than &mut self when calling
dxrcy
commented
Jan 7, 2025
src/debugger/error.rs
Outdated
There was a problem hiding this comment.
Error messages (and enum variant names) may need to change
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See proposal: #43