Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[scripts][dependency] Add messaging for forced script downloads #6973

Merged
merged 4 commits into from
Nov 11, 2024

Conversation

MahtraDR
Copy link
Collaborator

@MahtraDR MahtraDR commented Nov 8, 2024

Adds messaging when scripts are force-checked, and adds the option to force-check all scripts.

Resolves #6970

@Kiriawen
Copy link
Contributor

Kiriawen commented Nov 8, 2024

usage would be ;eq force_refresh_scripts ?

@MahtraDR
Copy link
Collaborator Author

MahtraDR commented Nov 8, 2024

usage would be ;eq force_refresh_scripts ?

There are two commands.

One - Force-gets all scripts (I am not sure we actually want this, we may only want it to CHECK all scripts, and get the ones that are out of date?)

;eq force_refresh_scripts

Two - force-gets one script

;eq get_script('script-name')

Note this should resolve #6970 however we end up tuning it.

@Kiriawen
Copy link
Contributor

Kiriawen commented Nov 9, 2024

yeah having it check for updates would be better than redownloading everything. Save on bandwidth at least

@Kiriawen
Copy link
Contributor

Kiriawen commented Nov 9, 2024

though having both a way to force a redownload of everything and a way to just check for updated files wouldn't be a bad idea either.

@MahtraDR
Copy link
Collaborator Author

MahtraDR commented Nov 9, 2024

though having both a way to force a redownload of everything and a way to just check for updated files wouldn't be a bad idea either.

The way it works now, it'll check every file and redownload if they're out of date or don't exist. Is that good enough here?

@Kiriawen
Copy link
Contributor

yep, that works. That's what I was expecting.

@MahtraDR MahtraDR merged commit 82dfcd1 into rpherbig:master Nov 11, 2024
2 checks passed
@MahtraDR MahtraDR deleted the dependency_script_checks branch November 11, 2024 21:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Dependency] Add update command function
2 participants