Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix the module/updateinfo.feature tests #1548

Open
jan-kolarik opened this issue Sep 6, 2024 · 1 comment
Open

Fix the module/updateinfo.feature tests #1548

jan-kolarik opened this issue Sep 6, 2024 · 1 comment

Comments

@jan-kolarik
Copy link
Member

Quoted from #1547:

After merging #1540, it was revealed that this test in module/updateinfo.feature wasn't actually testing anything, and the behavior it intends to test is (and has long been?) broken. The test was expecting an empty stdout (or <REPOSYNC>), which it was getting, but only after refactoring the tests did we notice the message on stderr:

Unknown argument "--list" for command "updateinfo".

For now, I've updated the test to call the correct command, updateinfo list, and disabled the test since it is now failing (but in a more valid way):

Assertion Failed: Stdout is not empty, it contains:
Name                   Type        Severity                  Package              Issued
FEDORA-2019-0329090518 enhancement none     nodejs-1:8.14.0-1.x86_64 2019-03-29 00:00:00

Another option would be to fix the test to use the correct command, but leave it enabled and failing.

cc @pkratoch, do you have an idea of what the problem is and how long it might take to fix? If it's complicated/low priority, we can go ahead and disable the test and put an issue on the backlog for it, otherwise maybe it's better to go ahead and fix it instead of disabling then immediately re-enabling it.

@kontura
Copy link
Contributor

kontura commented Sep 16, 2024

I believe the problem is here: https://github.com/rpm-software-management/dnf5/blob/main/libdnf5/advisory/advisory_collection.cpp#L74-L77 it wasn't possible to implement the applicability check when I was working on it.

However now we module support so we could resolve this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Backlog
Development

No branches or pull requests

2 participants