Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[modularity] Module defaults #340

Open
mhatina opened this issue Oct 27, 2017 · 6 comments
Open

[modularity] Module defaults #340

mhatina opened this issue Oct 27, 2017 · 6 comments

Comments

@mhatina
Copy link

mhatina commented Oct 27, 2017

We need ini file with defaults for testing purposes (enable module based on installing rpm).

File should look like this:

[httpd]
name=httpd
stream=2.4
profiles=default, doc

and should be saved in /etc/dnf/modules.defaults.d/ as httpd.defaults.

@ignatenkobrain
Copy link
Contributor

So what's the problem? Create it ;)

@kkaarreell
Copy link
Contributor

kkaarreell commented Oct 27, 2017

The idea was to have a dedicated step that would be referring to modules rather than using the generic step for ini files in the *.feature file.
Something like

(Given) a module system profile {basename}
 | Section | Key | Value |
...

@mhatina @dmach
Does the step name look acceptable or do you have different proposal?

@ignatenkobrain
Copy link
Contributor

Why to create such weird steps? There is already one to create ini files...

dnf-docker-test/features/steps/file_steps.py:@given('an INI file "{filepath}" with')

@kkaarreell
Copy link
Contributor

Because it would make the test scenario more readable. This is the concept of the BDT.

@ignatenkobrain
Copy link
Contributor

In this case I don't think that it makes any time more readable...

@kkaarreell
Copy link
Contributor

With that argument even the INI step is useless as we already have step_a_file_filepath_with.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants