Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix /var/cache/dnf and /etc/yum packaging #2118

Merged

Conversation

ppisar
Copy link
Contributor

@ppisar ppisar commented Aug 13, 2024

This patch set improves packaging:

  • Moves /var/cache/dnf from dnf package to python3-dnf
  • Removes long broken preview yum_compat_level
  • Simplifies %files dnf section for both yum_compat_levels
  • Fixes ownership of /etc/yum tree

I tested it on Fedora 41 and Fedora 40. The only externally visible change on binary packages is the move of /var/cache/dnf directory to python3-dnf.

The cache directory is used by /usr/bin/dnf-3 program packaged
in python3-dnf. dnf package requires python3-dnf.
CMake build script stopped creating yum4 executable when
Python 2 support was removed with commit
92f03d1 ([spec] Remove python 2).

Therefore the preview level cannot be enabled anymore and this patch
removes it to simplify the spec file.
Miminal level is a subset of full level.
This patch fixes two mistakes:

(1) In minimal yum_compat_levels (default one) rpmbuild complained:

    RPM build warnings:
        File not found: /home/test/rpmbuild/BUILDROOT/dnf-4.21.0-4.fc40.x86_64/etc/yum/pluginconf.d
        File not found: /home/test/rpmbuild/BUILDROOT/dnf-4.21.0-4.fc40.x86_64/etc/yum/protected.d
        File not found: /home/test/rpmbuild/BUILDROOT/dnf-4.21.0-4.fc40.x86_64/etc/yum/vars

(2) In full yum_compat_levels /etc/yum directory was not owned by yum package
@m-blaha m-blaha self-assigned this Aug 19, 2024
Copy link
Member

@m-blaha m-blaha left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@m-blaha m-blaha merged commit f29a017 into rpm-software-management:master Aug 19, 2024
6 of 9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants