Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rhel-10.0: Fix for RHEL-49671 #2133

Open
wants to merge 4 commits into
base: rhel-10.0
Choose a base branch
from

Conversation

ppisar
Copy link
Contributor

@ppisar ppisar commented Sep 20, 2024

This patch set is a backport of the following commits to rhel-10.0 branch:

Upstream commit: 5c050ba
Upstream commit: 6120fe5
Upstream commit: e253558
Upstream commit: a1aa8d0

Resolves: https://issues.redhat.com/browse/RHEL-49671

This similar to rhel-9.6 PR #2127. @dcantrell, could you review it?

…anges

Upstream commit: 5c050ba

On ostree-based systems, users can use dnf to customize the
environment but those changes will be lost at the next ostree-based
image update.  If you want to retain changes between ostree-updates
you need to make use of rpm-ostree right now.

Signed-off-by: David Cantrell <dcantrell@redhat.com>
Resolves: https://issues.redhat.com/browse/RHEL-49671
@pep8speaks
Copy link

pep8speaks commented Sep 20, 2024

Hello @ppisar! Thanks for updating this PR. We checked the lines you've touched for PEP 8 issues, and found:

There are currently no PEP 8 issues detected in this Pull Request. Cheers! 🍻

Comment last updated at 2024-09-20 12:05:59 UTC

jmarrero and others added 3 commits September 20, 2024 14:05
Upstream commit: 6120fe5

This changes the is_container() func for _is_bootc_host()
and updates the logic and message. This should detect on
all ostree and bootc hosts to date that are not using
bootc usroverlay or ostree admin unlock for development
purposes.

Resolves: https://issues.redhat.com/browse/RHEL-49671
Upstream commit: a1aa8d0

Some people use --installroot on a read-only bootc system to install
a system into a chroot subtree. However, current bootc check did not
take into account --installroot and rejected the operation.

This patch augments the check for the installroot being different
from /.

It's pointless to check for installroot writability here because
installroot is written before this check when updating the
repositories and computing a transaction. Moving this check sooner
would not help because some directories (/opt, /) are kept read-only
even on writable bootc.

Resolves: rpm-software-management#2108
Resolves: https://issues.redhat.com/browse/RHEL-49671
@ppisar
Copy link
Contributor Author

ppisar commented Sep 20, 2024

I correct the end of files in the Python sources.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants