-
Notifications
You must be signed in to change notification settings - Fork 78
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Is there a ROS2 version? #7
Comments
Hi, supporting ROS2 is on todo list. Not sure exactly when I can add the feature, but hopefully soon. I expect the implementation should be similar to how OpenVINS is supporting it. |
@WoosikLee2510 That would be great! |
@WoosikLee2510 any updates? |
Is there any way to assist you in porting it to ros2? I would like to use the project in our ros2 system, and also have some time to spend on porting it to ros2. So if you have a branch where you already started that would be great, otherwise I could give it a go. Are there larger things that need to change in order to port it to ros2, or is it more or less just the things mentioned in here? |
I have something that builds and also starts, the simulation also looks good. But testing it with euroc_mav datasets doesn't quite work. I don't understand the math behind the whole thing good enough to figure out, what's going wrong, so if you could have a look at it @WoosikLee2510, that would be great! I started a pull request in #25 |
@WoosikLee2510 Any updates on this ? |
I think with the QoS thing sorted out it works with ROS2, I get good results with the euroc_mav datasets. I think the code needs some cleaning up, and I think I'll get to that in the next few weeks. @WoosikLee2510 if you have the time to add some comments for me to review I'll have a look at them. |
I created a cleaner port: #38 |
Thanks @sacovo |
We are not using those two sensors on our platform so I can't tell you for sure. In the simulation (with ros2 run mins simulation) it seemed to work with the simulated lidar input. I think the kitty dataset has both of those, so it might be possible to test it with those datasets. Regarding Lidar, do you want to use a 2d or a 3d lidar? As far as I can tell the package expects a point cloud, instead of a laser scan, so I think another conversion from ROS message to internal datatype would be required. |
@sacovo Thanks for your reply. I would like to fuse 3D LiDAR+GPS+camera+IMU. I will test and share feedback. |
Thanks for the great work.
Is there a plan to provide ROS2 support ?
The text was updated successfully, but these errors were encountered: