Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Is there a ROS2 version? #7

Open
mzahana opened this issue Oct 14, 2023 · 13 comments
Open

Is there a ROS2 version? #7

mzahana opened this issue Oct 14, 2023 · 13 comments
Labels
enhancement New feature or request

Comments

@mzahana
Copy link

mzahana commented Oct 14, 2023

Thanks for the great work.

Is there a plan to provide ROS2 support ?

@WoosikLee2510 WoosikLee2510 added the enhancement New feature or request label Oct 14, 2023
@WoosikLee2510
Copy link
Member

Hi, supporting ROS2 is on todo list. Not sure exactly when I can add the feature, but hopefully soon. I expect the implementation should be similar to how OpenVINS is supporting it.

@mzahana
Copy link
Author

mzahana commented Oct 15, 2023

@WoosikLee2510 That would be great!
Thank you.

@mzahana
Copy link
Author

mzahana commented Feb 9, 2024

@WoosikLee2510 any updates?

@WoosikLee2510
Copy link
Member

@mzahana slowly working on it. Sorry for the delay. If you want to try it yourself, you can refer to OpenVINS to grab how you can implement it - which is what I am working on.

@sacovo
Copy link

sacovo commented Mar 12, 2024

Is there any way to assist you in porting it to ros2? I would like to use the project in our ros2 system, and also have some time to spend on porting it to ros2. So if you have a branch where you already started that would be great, otherwise I could give it a go.

Are there larger things that need to change in order to port it to ros2, or is it more or less just the things mentioned in here?

@sacovo
Copy link

sacovo commented Mar 16, 2024

I have something that builds and also starts, the simulation also looks good. But testing it with euroc_mav datasets doesn't quite work. I don't understand the math behind the whole thing good enough to figure out, what's going wrong, so if you could have a look at it @WoosikLee2510, that would be great!

I started a pull request in #25

@mzahana
Copy link
Author

mzahana commented Apr 23, 2024

@WoosikLee2510 Any updates on this ?

@WoosikLee2510
Copy link
Member

Hi, @mzahana . I am truly sorry for sitting on this update so long. How is #25? I will try to look into it too... And much appreciated to @sacovo !

@sacovo
Copy link

sacovo commented May 8, 2024

I think with the QoS thing sorted out it works with ROS2, I get good results with the euroc_mav datasets. I think the code needs some cleaning up, and I think I'll get to that in the next few weeks. @WoosikLee2510 if you have the time to add some comments for me to review I'll have a look at them.

@sacovo
Copy link

sacovo commented Aug 7, 2024

I created a cleaner port: #38

@mzahana
Copy link
Author

mzahana commented Sep 17, 2024

Thanks @sacovo
Does your ros2 branch support GPS and LIDAR ?

@sacovo
Copy link

sacovo commented Sep 23, 2024

We are not using those two sensors on our platform so I can't tell you for sure. In the simulation (with ros2 run mins simulation) it seemed to work with the simulated lidar input.

I think the kitty dataset has both of those, so it might be possible to test it with those datasets.

Regarding Lidar, do you want to use a 2d or a 3d lidar? As far as I can tell the package expects a point cloud, instead of a laser scan, so I think another conversion from ROS message to internal datatype would be required.

@mzahana
Copy link
Author

mzahana commented Sep 23, 2024

@sacovo Thanks for your reply. I would like to fuse 3D LiDAR+GPS+camera+IMU. I will test and share feedback.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants