Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Sanity Check #4

Open
mathieuboudreau opened this issue May 23, 2020 · 1 comment
Open

Sanity Check #4

mathieuboudreau opened this issue May 23, 2020 · 1 comment
Assignees
@agahkarakuzu

Comments

@mathieuboudreau
Copy link
Collaborator

Hi Agah!

Could you do a quick sanity check of this repo when you have the chance? i.e. Check if README is clear, check uploaded OSF.io datasets, try running the notebook, etc.
@agahkarakuzu
Copy link

Hi @mathieuboudreau, I followed the steps and it worked smoothly, great job! 🎊

I chose 3T_NIST as config and tested only that one and did not wait for all 55 datasets to fit. I assume that your main concern with the sanity check was the env installation, which is ✅.

I have some suggestions:

  • Removing docs folder from qMRLab and removing AMICO to reduce repo size
  • Suppressing image display when the fit is completed
  • Saving default state of the notebook like this:
    image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@agahkarakuzu agahkarakuzu

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@mathieuboudreau @agahkarakuzu