Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feat: Support Bridge and Proxy interactions #237

Merged
merged 24 commits into from
Sep 16, 2024
Merged

Feat: Support Bridge and Proxy interactions #237

merged 24 commits into from
Sep 16, 2024

Conversation

nicov-iov
Copy link
Collaborator

This PR contains:

Main changes:

  • feat: support Bridge and Proxy interactions
  • feat: support simulations (for write methods)

Other changes:

  • cleaner code in general (structure, errors handling, etc)
  • support accounts switching during interactions
  • beta feature disclaimer

nicov-iov and others added 24 commits July 31, 2024 20:03
@nicov-iov
fix: remove extra try-catch (metamask error code wasnt being propagat…
c8141d5 
…ed correctly)
@nicov-iov
wip: add support for bridge interactions (awaiting bridge methods list)
74b5894
@nicov-iov
feat: add allowed bridge methods
5b07cdb
@nicov-iov
feat: add simulation capabilities to write methods
5718d5b
@nicov-iov
feat: major code refactor for contract interactions feature
83b1be9
@nicov-iov
Merge branch 'staging' into feat/DV-188/support-bridge-interactions
c01a3fc
@nicov-iov
Merge pull request #233 from rsksmart/feat/DV-188/support-bridge-inte…
eac2920 
…ractions

Support bridge interactions. Support simulated calls.
@nicov-iov
fix: minor fixes
7eea540
@nicov-iov
Merge branch 'feat/DV-188/support-bridge-interactions' into staging
3bf2ff7
@nicov-iov
chore: remove unsupported proxies warning
0c35b3f
@nicov-iov
refactor: implement proxy method tabs. Minor fixes
754f40e
@nicov-iov
fix: remove flag
d968f4f
@nicov-iov
wip:
2f438a6 
- fetch implementation details
- Separate proxy and implementation interaction state
- unique id for method inputs (ContractMethods component)
- (in process) create ethers contract instances for implementation contract
@nicov-iov
feat: add disclaimer
80cb892
@nicov-iov
fix: error msg fix
b8e2900
@nicov-iov
feat: major refactor, support contract interactions
a8cc539 
- update tabs logic
- update abi parsing logic for contract instances and interactive methods registration
- centralize contract instances
- better errors handling
- abstract contract interactions utils
@nicov-iov
feat:
6fec96f 
- add loading skeleton
- handle unverified implementation case (disable interactions and warn user)
@nicov-iov
refactor: replace loader
078f506
@nicov-iov
feat:
754e6de 
- support different accounts interaction
- abstract contract instances creation
@nicov-iov
refactor: Use signer for all interaction types if user connects its w…
ecddae2 
…allet
@nicov-iov
fix: network for implementation address url
f97b5a3
@nicov-iov
fix: conditional rendering for implementation-address-field
4d0bfb3
@nicov-iov
fix: (QA) border case: switch network before connecting (now displays…
54900f6 
… network changed msg)
@nicov-iov
chore: update version
2c7f96e
krlz16
krlz16 approved these changes Sep 16, 2024
View reviewed changes
Copy link
Collaborator

@krlz16 krlz16 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@IOVgomezdn IOVgomezdn merged commit 5774a4b into develop Sep 16, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@krlz16 krlz16 krlz16 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@nicov-iov @krlz16 @IOVgomezdn