Skip to content

Commit

Permalink
🐺 Replace opn with shell.openItem, upgrade dependencies
Browse files Browse the repository at this point in the history
  • Loading branch information
albertzak committed Apr 11, 2019
1 parent 7e553e1 commit d38da75
Show file tree
Hide file tree
Showing 3 changed files with 501 additions and 534 deletions.
8 changes: 5 additions & 3 deletions app/electron/main/print.js
Original file line number Diff line number Diff line change
@@ -1,8 +1,7 @@
const fs = require('fs')
const path = require('path')
const open = require('opn')
const temp = require('temp')
const { ipcMain } = require('electron')
const { shell, ipcMain } = require('electron')
const logger = require('./logger')

const start = (options) => {
Expand Down Expand Up @@ -38,7 +37,10 @@ const print = (options) => {
return
}
logger.info('[Print] Saved pdf to path: ' + pdfPath)
open(pdfPath)
const ok = shell.openItem(pdfPath)
if (!ok) {
logger.error('[Print] failed to open pdf: ' + pdfPath)
}
})
})
})
Expand Down
9 changes: 4 additions & 5 deletions app/electron/package.json
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
{
"name": "rosalind",
"productName": "Rosalind",
"version": "0.0.200",
"version": "0.0.201",
"private": true,
"description": "Rosalind",
"author": {
Expand All @@ -17,22 +17,21 @@
"devDependencies": {
"electron": "^4.0.5",
"electron-builder": "^20.38.5",
"electron-packager": "^12.1.1",
"electron-packager": "^13.1.1",
"shelljs": "^0.8.2"
},
"dependencies": {
"@sentry/electron": "^0.8.1",
"@sentry/electron": "^0.17.1",
"chokidar": "^2.0.4",
"electron-localshortcut": "^3.1.0",
"electron-updater": "^4.0.6",
"fs-extra": "^7.0.0",
"glob": "^7.1.2",
"iconv-lite": "^0.4.24",
"lodash": "^4.17.11",
"opn": "^5.3.0",
"pkginfo": "^0.4.1",
"request": "^2.88.0",
"temp": "^0.8.3",
"temp": "^0.9.0",
"windows-shortcuts-appid": "^0.3.2",
"winston": "^2.4.4",
"winston-papertrail": "^1.0.5"
Expand Down
Loading

0 comments on commit d38da75

Please sign in to comment.