Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

invalid_command_spec.rb, test 'returns a command response with age=undefined' should not run for core 3.1.2 #345

Closed
sveitech opened this issue Nov 21, 2023 · 3 comments · Fixed by #346

Comments

@sveitech
Copy link

The ageState=undefined was introduced in core 3.1.3 (https://rsmp-nordic.github.io/rsmp_specifications/core/3.1.3/applicability/basic_structure.html#command-messages). The test should be limited to core 3.1.3 and above.

@emiltin
Copy link
Contributor

emiltin commented Nov 28, 2023

Fixed with #346.
Note that you need to set the core version in the test config before this has any effect - the filterering is done against the version set in the test config, not what the equipment reports when connecting, eg in swarco_itc3.yaml:

restrict_testing:
  core_version: 3.1.2
  sxl_version: 1.0.13

This should reflect the versions that the equipment runs. It's done this way to avoid faulty equipment affecting what tests are run.

@sveitech
Copy link
Author

This is what I have in the config:

restrict_testing:
core_version: 3.1.5
sxl_version: 1.0.13

@emiltin
Copy link
Contributor

emiltin commented Nov 28, 2023

As long as that reflects what the equipment runs, that should be ok.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants