Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

modes_spec, "yellow flash affects all signal groups" fails due to undocumented timeout value yellow_flash. #363

Closed
sveitech opened this issue Jan 11, 2024 · 2 comments

Comments

@sveitech
Copy link

This pull request introduced a new timeout value called yellow_flash: 1df95a6

The test in the title breaks if the field is not added to the config.

Consider having default values for new fields introduced to the config.

The documentation should also be updated. The field is not documented on https://rsmp-nordic.github.io/rsmp_validator/config/

@emiltin emiltin added the enhancement New feature or request label Jan 12, 2024
@emiltin
Copy link
Contributor

emiltin commented Jan 12, 2024

Hi,
I've added the helper Validator.get_config() to fetch a config in the PR #364.

If the config is missing it will stop with an error, telling you that it's missing.

I've updated (in the PR) all test to use the helper.

The helper also supports providing a default value, which will be used if the config is missing. but it's not currently used in any tests. In general I think it's better to avoid default values, and instead rely on an explicit config for the equipment you're testing.

I've updated the documentation on https://rsmp-nordic.github.io/rsmp_validator/config/ to include yellow_flash.

@emiltin emiltin removed the enhancement New feature or request label Jan 12, 2024
@emiltin
Copy link
Contributor

emiltin commented Jan 17, 2024

Improved with #364.

@emiltin emiltin closed this as completed Jan 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants