Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

don't test S0003, S0004, S0018 on sxl 1.2, as they are depreciated #347

Merged
merged 1 commit into from
Nov 28, 2023
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions config/gem_tlc.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -48,3 +48,4 @@ alarms:
component: DL1
restrict_testing:
sxl_version: 1.2
core_version: 3.1.3
4 changes: 2 additions & 2 deletions spec/site/tlc/io_spec.rb
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,7 @@
# 1. Given the site is connected
# 2. When we read input with S0029
# 3. Then we should receive a valid response
specify 'is read with S0003' do |example|
specify 'is read with S0003', sxl: '<1.2' do |example|
Validator::Site.connected do |task,supervisor,site|
request_status_and_confirm site, "input status",
{ S0003: [:inputstatus] }
Expand Down Expand Up @@ -99,7 +99,7 @@
# 2. When we subscribe to S0004
# 3. We should receive a status updated
# 4. And the outputstatus attribute should be a digit string
specify 'is read with S0004', sxl: '>=1.0.7' do |example|
specify 'is read with S0004', sxl: ['>=1.0.7','<1.2'] do |example|
Validator::Site.connected do |task,supervisor,site|
prepare task, site
request_status_and_confirm site, "output status",
Expand Down