Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Validator.get_config helper to fetch config #364

Merged
merged 2 commits into from
Jan 17, 2024
Merged

Validator.get_config helper to fetch config #364

merged 2 commits into from
Jan 17, 2024

Conversation

emiltin
Copy link
Contributor

@emiltin emiltin commented Jan 12, 2024

Fetches a config (optionally using a default value). Raise an error if not found.
This PR updates all tests to use this helper.

Using this helper will stop a test with a clear error message if a config is missing. Otherwise a test might run but fail in weird ways.

@emiltin
Copy link
Contributor Author

emiltin commented Jan 17, 2024

Note that if a test setup was missing some configuration, and nil was somehow working as a default, running the test will not abort with a notice that the config is missing. In that case, just add the missing config to your test config.

@emiltin emiltin merged commit 7272798 into main Jan 17, 2024
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant