Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix docker workflow by running on push to main, rather than master #368

Merged
merged 1 commit into from
Jan 17, 2024

Conversation

emiltin
Copy link
Contributor

@emiltin emiltin commented Jan 17, 2024

No description provided.

@emiltin
Copy link
Contributor Author

emiltin commented Jan 17, 2024

It means packages on https://github.com/orgs/rsmp-nordic/packages?repo_name=rsmp_validator was not updated. Should be fixed, but can't verify until this PR is merged to main :-)

@emiltin emiltin merged commit 514b239 into main Jan 17, 2024
6 checks passed
@emiltin
Copy link
Contributor Author

emiltin commented Jan 17, 2024

There are a number of build warnings, see: https://github.com/rsmp-nordic/rsmp_validator/actions/runs/7553773064
@otterdahl do you want to have a look at fixing those?

@emiltin
Copy link
Contributor Author

emiltin commented Jan 17, 2024

The packages is now being build: https://github.com/rsmp-nordic/rsmp_validator/pkgs/container/rsmp_validator.

@otterdahl
Copy link
Contributor

There are a number of build warnings, see: https://github.com/rsmp-nordic/rsmp_validator/actions/runs/7553773064 @otterdahl do you want to have a look at fixing those?

I believe that build-push-action needs to updated. I've created a PR #370, but I can't verify because the github action won't run until merged to main. I'll merge anyway and we'll see.

@otterdahl
Copy link
Contributor

Seems to be fixed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants