Touch Bar support #345
Open
Touch Bar support #345
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- change keyboard shortcuts as the previous conflicted with the search feature (which overrode)
- Compose button, and prev/next conversation navigation
Selected conversation would not be found correctly if there were non-selected unread conversations.
|
Since I don't have a computer with TouchBar, I unfortunately have no way of testing this. |
|
After building and running in Xcode, you can enable the Touch Bar simulator from the Window menu (⌘⇧5). |
|
@rsms You can also test it with Touch Bar Simulator (No Xcode needed). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Basic Touch Bar support: compose button, and prev/next conversation navigation.
Also fixes prev/next navigation and changes keyboard shortcuts to ⌘[ and ], as ⌃[⇧]⇥ conflicts with the search feature (and the page overrides)(see independent PR #410 for this change)