Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

iRODS file system setup UX #39

Open
ll4strw opened this issue Jun 28, 2024 · 6 comments
Open

iRODS file system setup UX #39

ll4strw opened this issue Jun 28, 2024 · 6 comments
Assignees
Labels
enhancement New feature or request

Comments

@ll4strw
Copy link
Collaborator

ll4strw commented Jun 28, 2024

Hello RSpace team,
I propose the following changes to the page/routines where a sysadmin sets up a remote iRODS file system integration.

  • The label URL should be substituted by iRODS Host and a tooltip should hint that an iRODS host can be either a hostname or an IP address without protocol.
  • Set a default iRODS port equal to 1247 if none specified. Currently if no port is specified, any user trying to add an iRODS disk gets an error like Something went wrong: For input string: "".
  • Currently, this integration supports only the iRODS native authentication method. It would be nice if the auth method defaulted to native if a sysadmin sets up an iRODS integration, just to avoid confusion and to make it more specific to iRODS.
  • The label Home Directory does not seem to be appropriate in the form to set up a remote iRODS file system by a systemadmin. Instead, I propose iRODS Search Path because that is the root path to search for users collections within iRODS.
@ll4strw ll4strw added the enhancement New feature or request label Jun 28, 2024
@mKowalski256
Copy link
Contributor

@tilorspace @rs-nicof could you evaluate these suggestions?

Part of them was already implemented by @ll4strw in suggested PR#40. I've started test AWS server for previewing these changes.

@rs-nicof
Copy link
Contributor

rs-nicof commented Jul 2, 2024

@tilorspace @rs-nicof could you evaluate these suggestions?

Part of them was already implemented by @ll4strw in suggested PR#40. I've started test AWS server for previewing these changes.

Hi all, to me I thibnk they are all sensible and good improvements.
My doubt is on the bullet point 3 (the native method). I do not fullyt understand what is being asked, can we possibly have an use case?

@ll4strw
Copy link
Collaborator Author

ll4strw commented Jul 2, 2024

@rs-nicof Bullet point 3 is just a minor aesthetic modification/suggestion. The default authentication method in iRODS is called native, but it is essentially a username/password method. By using the label native in the setup form, we could just make that form more iRODS specific (centric).

@ll4strw
Copy link
Collaborator Author

ll4strw commented Jul 2, 2024

I just noticed some minor changes that I need to add to #40 to make sure that the custom iRODS labels do not affect the labels for other storage types.

ll4strw added a commit to ll4strw/rspace-web that referenced this issue Jul 2, 2024
Retrieve and use default labels from system.properties.
mKowalski256 pushed a commit to ResearchSpace-ELN/rspace-web that referenced this issue Jul 3, 2024
Retrieve and use default labels from system.properties.
@mKowalski256
Copy link
Contributor

@tilorspace @rs-nicof I've restarted test instance with latest changes, check: https://irods-ui-changes-4.researchspace.com.

@rs-nicof
Copy link
Contributor

rs-nicof commented Jul 3, 2024

@tilorspace @rs-nicof I've restarted test instance with latest changes, check: https://irods-ui-changes-4.researchspace.com.

@mKowalski256
It looks like sysadmin user does not login for some reason, plus If you connect with the user1 the fielstore is not enabled

ll4strw added a commit to ll4strw/rspace-web that referenced this issue Jul 4, 2024
Retrieve and use default labels from system.properties.
ll4strw added a commit to ll4strw/rspace-web that referenced this issue Jul 5, 2024
ll4strw added a commit to ll4strw/rspace-web that referenced this issue Jul 5, 2024
Retrieve and use default labels from system.properties.
mKowalski256 added a commit that referenced this issue Aug 15, 2024
Retrieve and use default labels from system.properties.

---------

Co-authored-by: Maciej Kowalski <mKowalski256@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

4 participants