RSDEV-326 Update existing tests and add new tests covering time validation for sample fields #88
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
src/test/java/com/researchspace/api/v1/controller/SamplesApiControllerMVCIT.java
Outdated
Show resolved
Hide resolved
… for valid and invalid time formats. update existing tests after adding time field to example sample.
rs-fraser
force-pushed
the
rsdev-326-backend-time-validation
branch
from
4f86aa9
to
787f498
Compare
… for csv file tests after adding time field to complex sample template.
rs-fraser
commented
Aug 20, 2024
rs-fraser
changed the title
rs-nicof
reviewed
Aug 20, 2024
src/test/java/com/researchspace/api/v1/controller/SamplesApiControllerMVCIT.java
Outdated
Show resolved
Hide resolved
|
It looks good to me, I'ìve added just a minor comment |
mKowalski256
approved these changes
Aug 26, 2024
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR uses the new "time" type fromrspace-core-modelso that we can validate times are in the correct format for custom template fields in inventory samples., and adds some mvc tests around that validation.This PR updates existing tests now that the
complexSampleTemplateused in many tests has a "time" field added, which previously was the only type of sample field missing from that template.Also added some tests around the validation of time fields. Validation has been added in the related
rspace-webPR: https://github.com/rspace-os/rspace-core-model/pull/7/files