Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RSDEV-352: remove old baseline db script #179

Conversation

mKowalski256
Copy link
Contributor

@mKowalski256 mKowalski256 commented Nov 5, 2024

The ecat5dev-baseline2014-1-24.sql script was effectively replaced by rs-dbbaseline-utf8.sql, and after looking into changes between the two they are basically the same, apart from charset encoding for which I believe we want utf8 as default anyway (that matches prod db setup).

@mKowalski256 mKowalski256 changed the title RSDEV-352: remove ecat5dev-baseline2014-1-24.sql script RSDEV-352: remove old baseline db script Nov 5, 2024
@tuxRamon
Copy link
Contributor

tuxRamon commented Nov 6, 2024

Looks good. We've been using rs-dbbaseline-utf8.sql for a while now (it's what's been included with our packages the last few years and also forms the base of the db-template.sql file for the open source docker rspace).

I don't see any problem removing ecat5dev-baseline2014-1-24.sql and only keeping rs-dbbaseline-utf8.sql

@mKowalski256 mKowalski256 merged commit f59060e into rspace-os:main Nov 6, 2024
2 checks passed
@mKowalski256 mKowalski256 deleted the rsdev-352-unify-baseline-db-script branch November 6, 2024 10:15
@github-actions github-actions bot locked and limited conversation to collaborators Nov 6, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants