Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve clarity of documentation for focal weights #1263

Merged
merged 1 commit into from
Aug 24, 2023
Merged

Improve clarity of documentation for focal weights #1263

merged 1 commit into from
Aug 24, 2023

Conversation

ailich
Copy link
Contributor

@ailich ailich commented Aug 24, 2023

I've included some changes that I think would clarify w for focal. Some changes to the documentation include:

  • preferentially suggesting the use NA over 0 in w as this is safer since it masks those cells out of calculations rather than setting them to 0 which may affect calculations depending on the function.
  • Describes what the weights do in calculations and removes restriction that they must be between 0 and 1.
  • Slight edit to special case of mean stating that the weighted mean will be calculated rather than just saying 0's function like NA's.

@rhijmans rhijmans merged commit e098477 into rspatial:master Aug 24, 2023
1 check failed
@rhijmans
Copy link
Member

Thank you very much!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants