Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Watershed Analysis Methods #1477

Merged
merged 48 commits into from
May 29, 2024
Merged

Watershed Analysis Methods #1477

merged 48 commits into from
May 29, 2024

Conversation

ecor
Copy link
Contributor

@ecor ecor commented Apr 12, 2024

Dear Developers,

I kindly submit my contribution to "terra" package adding some watershed analysis functions which I need and I have developed within the package in my fork ecor/terra.

Here find attached a summary of the added functions written in C/C++ and declared as methods in R:

help("watershed2") ## it extracts a watershed from D8 flow direction
help("flowAccu2") ## Flow Accumulation
help("flowAccu2_weight") ## Flow Accumulation with weight for each pixels (e.g. Total Contributing Area expressed in m2 or km2 if the CRS is lat lon )
help("pitfinder2") ## it finds pits in a digital elevation model through D8 flow directions
help("NIDP2") ## Number of immediate adjacent cells flowing into each cell (Watershed Analysis)

See also discussions about the need of this kind of tools in the following issues:

#1221
#1180

I 'm available for any possible discussion.

Thank you for the job

Best

Emanuele Cordano
@ecor

ecor added 30 commits July 2, 2021 15:10
Merging : rspatial/master to ecor/master
Aligned with "rspatial" repo updates
Updates from rspatial fork - see Date
Update with current rspatial/terra
Merging with "rspatial"
Alignment with latest official version
Alignment with rspatial
alignement with "rspatial" master one
@rhijmans
Copy link
Member

rhijmans commented May 3, 2024

Thank you very much for all this work. I have been a bit busy but will have a look asap.

@rhijmans rhijmans merged commit dc9816e into rspatial:master May 29, 2024
4 checks passed
@ecor
Copy link
Contributor Author

ecor commented Jun 6, 2024

Thanks for accepting pull request. I just saw that the "watershed analysis" function names was changed. I will update the examples with the new names in order that all checks on examples work correctly. I will do ASAP and submit a new pull request. I also corrected my name and surname in the DESCRIPTION file.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants