Allow slimit to work with ply 3.6 #79
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
These values are expected by ply to be module names, not module instances. ply 3.6 will crash if actual modules are passed.
|
Could this be please merged |
Jormangeud
added a commit
to Jormangeud/jrg-overlay
that referenced
this pull request
Jul 29, 2016
metatoaster
added a commit
to calmjs/calmjs.parse
that referenced
this pull request
Jun 8, 2017
- Also note that the following issues were addressed, where applicable to the lexer or parser. - rspivak/slimit#52 - rspivak/slimit#54 - rspivak/slimit#57 - rspivak/slimit#59 - rspivak/slimit#62 - rspivak/slimit#65 - rspivak/slimit#70 - rspivak/slimit#73 - rspivak/slimit#79 - rspivak/slimit#81 - rspivak/slimit#82 - rspivak/slimit#90 - Will get the release out when I get some sleep.
|
I think this one has been superseded by #102 |
Jormangeud
added a commit
to Jormangeud/jrg-overlay
that referenced
this pull request
May 8, 2023
Jormangeud
added a commit
to Jormangeud/jrg-overlay
that referenced
this pull request
May 8, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Always set slimit.parser.*tab to strings
These values are expected by ply to be module names, not module
instances. ply 3.6 will crash if actual modules are passed.
Please note that the actual tab modules depend on the version of ply first used. Those modules are checked in, and not modified by this commit.