Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ASVS/MASVS fields for Findings #13

Open
wants to merge 10 commits into
base: master
Choose a base branch
from
Open

ASVS/MASVS fields for Findings #13

wants to merge 10 commits into from

Conversation

sgspinola
Copy link

Hi @rsrdesarrollo,

I thought it would be interesting to be able to relate each finding to the security requirement that, if implemented following the OWASP standards for web applications (ASVS) and mobile applications (MASVS), would have prevented it.

Since you're already using the testing guides, I considered this to be some valuable additional information.

Both fields have been added to the finding and finding template tables.

@sgspinola sgspinola changed the title Feature/asvs masvs ASVS/MASVS fields for Findings Sep 30, 2020
* Update hidden field values for cvss
* Update hidden fields values for cvss
Icons for environmental and temporal metrics.
@rsrdesarrollo
Copy link
Owner

The work is fine, but I can not add REQUIRED fields (like SCA and SAST) to the main branch if they are not completely work-flow independent.

Also, in order to avoid the unnecessary grow of model and forms definition, I rather prefer some kind of dynamic meta-field in assessment and findings to let you an everyone configure custom fields as they needed them.

The use of the full CVSS calculator is OK for me, at first it looks a little bit massive but, I think is a good idea.

@sgspinola
Copy link
Author

sgspinola commented Oct 2, 2020

You're right, I'll make them nullable.

About the model and forms definition growth, would you care to explain what you mean by "dynamic meta-field"? is there any example already in code?

Thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants