Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Language Problem :/ #70

Open
ShaiBY10 opened this issue Jul 20, 2023 · 2 comments
Open

Language Problem :/ #70

ShaiBY10 opened this issue Jul 20, 2023 · 2 comments
Labels
bug Something isn't working good first issue Good for newcomers help wanted Extra attention is needed

Comments

@ShaiBY10
Copy link

image

Only this tool works for my Moodle (So thank you very much :),
But I have problem with file names,
My Moodle resources are in Hebrew, is there any way which I can implement a language pack?
do you know how is it possible?

@rssws
Copy link
Owner

rssws commented Aug 23, 2023

Hi @ShaiBY10 ,

Thanks for the issue and sorry for the late reply. Currently, I don't have the capacity to work on this project. But I believe the issue is caused by moodle-files.ts#L74.

The purpose of the regex is to filter out "illegal" characters and return a valid one. However, \w only matches normal Unicode characters and won't match any extended Unicode characters. Hebrew and many other languages such as Chinese, Japanese, etc. should be supported as well.

If you have an interest, feel free to extend the regex and let it leave out special characters. It could be quite some work to support all languages and still return back a valid filename that will be accepted by different operating systems with different language packs installed.

@rssws rssws added bug Something isn't working help wanted Extra attention is needed good first issue Good for newcomers labels Aug 23, 2023
@ShaiBY10
Copy link
Author

I see, Thank you for the reply
I will give it a try maybe someday :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working good first issue Good for newcomers help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

2 participants