Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update CSS for better combination with revealjs #668

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

atusy
Copy link

@atusy atusy commented Mar 4, 2020

Regarding to rstudio/revealjs#57 , CSS in some frameworks possibly cause messy results on leaflet tiles.
This PR fixes it.

Here is an example messy result with revealjs (see reprex section for code).
Although @kazutan made PR on revealjs, I think making PR on leaflet fits better.

image

I did not add tests or update documentation because my change is limited to css.

reprex

Render an Rmd file with a following content.

---
output: revealjs::revealjs_presentation
---

```{r, echo=FALSE}
library(leaflet)
leaflet() %>% addTiles()
```

PR task list:

  • Update NEWS
  • Add tests (where appropriate)
    • R code tests: tests/testthat/
    • Visual tests: R/zzz_viztest.R
  • Update documentation with devtools::document()

@CLAassistant
Copy link

CLAassistant commented Mar 4, 2020

CLA assistant check
All committers have signed the CLA.

@atusy atusy changed the title Revealjs Update CSS for better combination with revealjs Mar 4, 2020
@ElenaDatak
Copy link

using CSS you can manage it :

.reveal section img {  
  border: 0;
  box-shadow: 0;
}

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants