Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use --fail flag for curl to prevent silent failures #831

Merged
merged 5 commits into from
Sep 4, 2024

Conversation

ianpittwood
Copy link
Collaborator

@ianpittwood ianpittwood commented Aug 29, 2024

  • Add common -fsSL flags to curl usage throughout project.
  • Fix Quarto tests for changes from 3-part to 2-part versions.

ianpittwood and others added 2 commits September 4, 2024 11:00
@ianpittwood ianpittwood requested review from cm421, melissa-barca and a team as code owners September 4, 2024 17:46
@ianpittwood ianpittwood requested review from tylfin and nunyunuymi and removed request for a team September 4, 2024 17:46
@ianpittwood ianpittwood changed the title Use --fail flag for curl in Quarto binary fetch Use --fail flag for curl to prevent silent failures Sep 4, 2024
Copy link
Contributor

@melissa-barca melissa-barca left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@ianpittwood ianpittwood merged commit 8336596 into dev Sep 4, 2024
37 checks passed
@ianpittwood ianpittwood deleted the fix-quarto-download-silent-fail branch September 4, 2024 20:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants